From 37337bf9eaec642ba55c4d02932f38ee3be6e99c Mon Sep 17 00:00:00 2001 From: Freek van de Ven Date: Fri, 18 Nov 2022 15:26:26 +0100 Subject: [PATCH] fix: remove unused parameters --- CHANGELOG.md | 5 +++-- lib/src/models/table_theme.dart | 4 ++-- lib/src/timetable.dart | 5 +---- lib/src/widgets/table.dart | 16 ++++++---------- 4 files changed, 12 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index abe17bb..35bec5f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ * Updated TableTheme -## [0.0.3] - 24 Oktober 2022 +## [1.0.0] - 18 November 2022 -* Added horizontal variant \ No newline at end of file +* Added horizontal variant +* Adjustable size for the component diff --git a/lib/src/models/table_theme.dart b/lib/src/models/table_theme.dart index a0be28a..a3be046 100644 --- a/lib/src/models/table_theme.dart +++ b/lib/src/models/table_theme.dart @@ -9,7 +9,7 @@ class TableTheme { /// and offsets here. const TableTheme({ this.lineColor = const Color(0x809E9E9E), - this.lineHeight = 2, + this.lineStrokeWidth = 2, this.tableTextOffset = 5, this.lineDashDistance = 10, this.lineDashLength = 10, @@ -23,7 +23,7 @@ class TableTheme { final Color lineColor; /// The height of the lines. - final double lineHeight; + final double lineStrokeWidth; /// The distance between dashes on the line. final double lineDashDistance; diff --git a/lib/src/timetable.dart b/lib/src/timetable.dart index b94f42a..125c3dc 100644 --- a/lib/src/timetable.dart +++ b/lib/src/timetable.dart @@ -121,9 +121,6 @@ class _TimetableState extends State { alignment: Alignment.topLeft, children: [ table.Table( - tableHeight: widget.tableDirection == Axis.horizontal - ? _calculateTableHeight() - : 0, tableDirection: widget.tableDirection, startHour: widget.startHour, endHour: widget.endHour, @@ -287,7 +284,7 @@ class _TimetableState extends State { .size; } - double _calculateTableHeight() { + double calculateTableHeight() { var sum = 0.0; if (widget.mergeBlocks || widget.combineBlocks) { for (var orderedBlocks in (widget.mergeBlocks) diff --git a/lib/src/widgets/table.dart b/lib/src/widgets/table.dart index 0510516..d5ddd49 100644 --- a/lib/src/widgets/table.dart +++ b/lib/src/widgets/table.dart @@ -14,14 +14,10 @@ class Table extends StatelessWidget { this.tableDirection = Axis.vertical, this.hourDimension = 80, this.tableOffset = 20, - this.tableHeight = 400, this.theme = const TableTheme(), Key? key, }) : super(key: key); - //// The height of the table when the tableDirection is horizontal to render the vertical lines - final double tableHeight; - /// The [Axis] in which the table is layed out. final Axis tableDirection; @@ -67,7 +63,7 @@ class Table extends StatelessWidget { SizedBox(height: theme.tableTextOffset), Container( color: theme.lineColor, - width: theme.lineHeight, + width: theme.lineStrokeWidth, height: (size ?? MediaQuery.of(context).size).height - textSize.dy - theme.tableTextOffset, @@ -79,7 +75,7 @@ class Table extends StatelessWidget { SizedBox( width: hourDimension / 2 - textSize.dx / 2 - - theme.lineHeight, + theme.lineStrokeWidth, ), Column( mainAxisAlignment: MainAxisAlignment.start, @@ -100,7 +96,7 @@ class Table extends StatelessWidget { 2); i++) ...[ Container( - width: theme.lineHeight, + width: theme.lineStrokeWidth, height: i.isEven ? theme.lineDashLength : theme.lineDashDistance, @@ -137,7 +133,7 @@ class Table extends StatelessWidget { ), Expanded( child: Container( - height: theme.lineHeight, + height: theme.lineStrokeWidth, color: theme.lineColor, ), ) @@ -149,7 +145,7 @@ class Table extends StatelessWidget { margin: EdgeInsets.only( left: tableOffset, ), - height: theme.lineHeight, + height: theme.lineStrokeWidth, child: Row( children: [ for (int i = 0; @@ -165,7 +161,7 @@ class Table extends StatelessWidget { width: i.isEven ? theme.lineDashLength : theme.lineDashDistance, - height: theme.lineHeight, + height: theme.lineStrokeWidth, color: i.isEven ? theme.lineColor : Colors.transparent, ),