From 08532d368af9b95c2cc0376f828ec7c01b6464e2 Mon Sep 17 00:00:00 2001 From: Stein Milder Date: Mon, 26 Sep 2022 12:00:03 +0200 Subject: [PATCH] fix: remove alert dialog from module --- .../lib/example_registration_repository.dart | 4 +-- lib/src/registration_screen.dart | 34 ++++--------------- lib/src/service/registration_repository.dart | 2 +- 3 files changed, 9 insertions(+), 31 deletions(-) diff --git a/example/lib/example_registration_repository.dart b/example/lib/example_registration_repository.dart index 41e8064..b4fb2aa 100644 --- a/example/lib/example_registration_repository.dart +++ b/example/lib/example_registration_repository.dart @@ -5,8 +5,8 @@ import 'package:flutter_registration/flutter_registration.dart'; class ExampleRegistrationRepository with RegistrationRepository { @override - Future register(HashMap values) { + Future register(HashMap values) { debugPrint('register: $values'); - return Future.value(null); + return Future.value(true); } } diff --git a/lib/src/registration_screen.dart b/lib/src/registration_screen.dart index 643bd0e..c9eea7f 100644 --- a/lib/src/registration_screen.dart +++ b/lib/src/registration_screen.dart @@ -14,34 +14,12 @@ class RegistrationScreen extends StatelessWidget { Widget build(BuildContext context) { var translations = registrationOptions.registrationTranslations; - void showError(String error) => showDialog( - context: context, - builder: (BuildContext context) => AlertDialog( - content: Text(error), - actions: [ - TextButton( - onPressed: () => Navigator.pop( - context, - translations.closeBtn, - ), - child: Text( - translations.closeBtn, - ), - ), - ], - ), - ); - - void register(values) => registrationOptions.registrationRepository - .register(values) - .then( - (_) => registrationOptions.afterRegistration(), - ) - .catchError( - (error) { - showError( - error.toString(), - ); + void register(values) => + registrationOptions.registrationRepository.register(values).then( + (response) { + if (response) { + registrationOptions.afterRegistration(); + } }, ); diff --git a/lib/src/service/registration_repository.dart b/lib/src/service/registration_repository.dart index 9354855..27e2bab 100644 --- a/lib/src/service/registration_repository.dart +++ b/lib/src/service/registration_repository.dart @@ -1,5 +1,5 @@ import 'dart:collection'; mixin RegistrationRepository { - Future register(HashMap values); + Future register(HashMap values); }