fix: rename carouselController

This commit is contained in:
mike doornenbal 2024-08-07 10:50:04 +02:00
parent 815ca7b0b2
commit f2d1fb5262
4 changed files with 22 additions and 19 deletions

View file

@ -1,6 +1,7 @@
## 3.6.0 ## 3.6.0
* Added style parameter to `FlutterFormInputMultiLine` * Added style parameter to `FlutterFormInputMultiLine`
* Upgrade flutter_iconica_analysis to 7.0.0 * Upgrade flutter_iconica_analysis to 7.0.0
* Changed the name of the `CarouselController` to `FlutterInputCarouselController`
## 3.5.0 ## 3.5.0
* Added `selectableTimePredicate` to the `DateTimeInputField` constructor * Added `selectableTimePredicate` to the `DateTimeInputField` constructor

View file

@ -9,8 +9,8 @@ import "package:flutter_input_library/src/inputs/carousel/carousel_options.dart"
import "package:flutter_input_library/src/inputs/carousel/carousel_state.dart"; import "package:flutter_input_library/src/inputs/carousel/carousel_state.dart";
import "package:flutter_input_library/src/inputs/carousel/carousel_utils.dart"; import "package:flutter_input_library/src/inputs/carousel/carousel_utils.dart";
abstract class CarouselController { abstract class FlutterInputCarouselController {
factory CarouselController() => CarouselControllerImpl(); factory FlutterInputCarouselController() => CarouselControllerImpl();
bool get ready; bool get ready;
Future<void> get onReady; Future<void> get onReady;
@ -28,7 +28,7 @@ abstract class CarouselController {
void stopAutoPlay(); void stopAutoPlay();
} }
class CarouselControllerImpl implements CarouselController { class CarouselControllerImpl implements FlutterInputCarouselController {
final Completer<void> _readyCompleter = Completer<void>(); final Completer<void> _readyCompleter = Completer<void>();
CarouselState? _state; CarouselState? _state;

View file

@ -26,25 +26,25 @@ class CarouselSlider extends StatefulWidget {
CarouselSlider({ CarouselSlider({
required this.items, required this.items,
required this.options, required this.options,
CarouselController? carouselController, FlutterInputCarouselController? carouselController,
super.key, super.key,
}) : itemBuilder = null, }) : itemBuilder = null,
itemCount = items != null ? items.length : 0, itemCount = items != null ? items.length : 0,
_carouselController = carouselController != null _carouselController = carouselController != null
? carouselController as CarouselControllerImpl ? carouselController as CarouselControllerImpl
: CarouselController() as CarouselControllerImpl; : FlutterInputCarouselController() as CarouselControllerImpl;
/// The on demand item builder constructor/ /// The on demand item builder constructor/
CarouselSlider.builder({ CarouselSlider.builder({
required this.itemCount, required this.itemCount,
required this.itemBuilder, required this.itemBuilder,
required this.options, required this.options,
CarouselController? carouselController, FlutterInputCarouselController? carouselController,
super.key, super.key,
}) : items = null, }) : items = null,
_carouselController = carouselController != null _carouselController = carouselController != null
? carouselController as CarouselControllerImpl ? carouselController as CarouselControllerImpl
: CarouselController() as CarouselControllerImpl; : FlutterInputCarouselController() as CarouselControllerImpl;
/// [CarouselOptions] to create a [CarouselState] with. /// [CarouselOptions] to create a [CarouselState] with.
final CarouselOptions options; final CarouselOptions options;

View file

@ -100,16 +100,18 @@ class _DateInputFieldState extends State<DateTimeInputField> {
var userInput = ""; var userInput = "";
switch (inputType) { switch (inputType) {
case FlutterFormDateTimeType.date: case FlutterFormDateTimeType.date:
var unformatted = await showDatePicker( if (context.mounted) {
initialDate: initialDate, var unformatted = await showDatePicker(
context: context, initialDate: initialDate,
firstDate: firstDate, context: context,
lastDate: lastDate, firstDate: firstDate,
selectableDayPredicate: widget.selectableDayPredicate, lastDate: lastDate,
); selectableDayPredicate: widget.selectableDayPredicate,
userInput = unformatted != null );
? widget.dateFormat.format(unformatted) userInput = unformatted != null
: userInput; ? widget.dateFormat.format(unformatted)
: userInput;
}
case FlutterFormDateTimeType.dateTime: case FlutterFormDateTimeType.dateTime:
await getInputFromUser(FlutterFormDateTimeType.date) await getInputFromUser(FlutterFormDateTimeType.date)
@ -152,6 +154,7 @@ class _DateInputFieldState extends State<DateTimeInputField> {
} }
case FlutterFormDateTimeType.time: case FlutterFormDateTimeType.time:
var locale = MaterialLocalizations.of(context);
if (context.mounted) { if (context.mounted) {
userInput = await showTimePicker( userInput = await showTimePicker(
initialEntryMode: widget.timePickerEntryMode, initialEntryMode: widget.timePickerEntryMode,
@ -165,8 +168,7 @@ class _DateInputFieldState extends State<DateTimeInputField> {
).then( ).then(
(value) => value == null (value) => value == null
? "" ? ""
: MaterialLocalizations.of(context) : locale.formatTimeOfDay(value, alwaysUse24HourFormat: true),
.formatTimeOfDay(value, alwaysUse24HourFormat: true),
); );
} }
} }