From 532cc2abda5765050d02b5100da88c6fc7c892cf Mon Sep 17 00:00:00 2001 From: Bart Ribbers Date: Tue, 12 Sep 2023 11:08:55 +0200 Subject: [PATCH] fix(ci): resolve all linter issues --- analysis_options.yaml | 20 +--- example/analysis_options.yaml | 205 +--------------------------------- example/lib/main.dart | 26 ++--- 3 files changed, 15 insertions(+), 236 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 61b6c4d..4adea75 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -5,25 +5,7 @@ # IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be # invoked from the command line by running `flutter analyze`. -# The following line activates a set of recommended lints for Flutter apps, -# packages, and plugins designed to encourage good coding practices. include: package:flutter_lints/flutter.yaml linter: - # The lint rules applied to this project can be customized in the - # section below to disable rules from the `package:flutter_lints/flutter.yaml` - # included above or to enable additional rules. A list of all available lints - # and their documentation is published at - # https://dart-lang.github.io/linter/lints/index.html. - # - # Instead of disabling a lint rule for the entire project in the - # section below, it can also be suppressed for a single line of code - # or a specific dart file by using the `// ignore: name_of_lint` and - # `// ignore_for_file: name_of_lint` syntax on the line or in the file - # producing the lint. - rules: - # avoid_print: false # Uncomment to disable the `avoid_print` rule - # prefer_single_quotes: true # Uncomment to enable the `prefer_single_quotes` rule - -# Additional information about this file can be found at -# https://dart.dev/guides/language/analysis-options + rules: \ No newline at end of file diff --git a/example/analysis_options.yaml b/example/analysis_options.yaml index 933b8e7..f16eead 100644 --- a/example/analysis_options.yaml +++ b/example/analysis_options.yaml @@ -1,207 +1,4 @@ -# This file configures the analyzer, which statically analyzes Dart code to -# check for errors, warnings, and lints. -# -# The issues identified by the analyzer are surfaced in the UI of Dart-enabled -# IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be -# invoked from the command line by running `flutter analyze`. - -# The following line activates a set of recommended lints for Flutter apps, -# packages, and plugins designed to encourage good coding practices. include: package:flutter_lints/flutter.yaml linter: - # The lint rules applied to this project can be customized in the - # section below to disable rules from the `package:flutter_lints/flutter.yaml` - # included above or to enable additional rules. A list of all available lints - # and their documentation is published at - # https://dart-lang.github.io/linter/lints/index.html. - # - # Instead of disabling a lint rule for the entire project in the - # section below, it can also be suppressed for a single line of code - # or a specific dart file by using the `// ignore: name_of_lint` and - # `// ignore_for_file: name_of_lint` syntax on the line or in the file - # producing the lint. - rules: - always_use_package_imports: true - avoid_dynamic_calls: true - avoid_empty_else: true - avoid_print: true - avoid_relative_lib_imports: true - avoid_returning_null_for_future: true - avoid_slow_async_io: true - avoid_type_to_string: true - avoid_types_as_parameter_names: true - avoid_web_libraries_in_flutter: true - cancel_subscriptions: true - close_sinks: true - comment_references: false - control_flow_in_finally: true - diagnostic_describe_all_properties: false - empty_statements: true - hash_and_equals: true - list_remove_unrelated_type: true - literal_only_boolean_expressions: true - no_adjacent_strings_in_list: true - no_duplicate_case_values: true - no_logic_in_create_state: true - prefer_void_to_null: true - test_types_in_equals: true - throw_in_finally: true - unnecessary_statements: true - unrelated_type_equality_checks: true - use_build_context_synchronously: true - use_key_in_widget_constructors: true - valid_regexps: true - always_declare_return_types: true - always_put_control_body_on_new_line: true - always_put_required_named_parameters_first: true - always_require_non_null_named_parameters: true - always_specify_types: false - annotate_overrides: true - avoid_annotating_with_dynamic: false - avoid_bool_literals_in_conditional_expressions: true - avoid_catches_without_on_clauses: false - avoid_catching_errors: false - avoid_classes_with_only_static_members: true - avoid_double_and_int_checks: true - avoid_equals_and_hash_code_on_mutable_classes: false - avoid_escaping_inner_quotes: false - avoid_field_initializers_in_const_classes: true - avoid_function_literals_in_foreach_calls: true - avoid_implementing_value_types: true - avoid_init_to_null: true - avoid_multiple_declarations_per_line: true - avoid_null_checks_in_equality_operators: true - avoid_private_typedef_functions: true - avoid_renaming_method_parameters: true - avoid_return_types_on_setters: true - avoid_returning_null: true - avoid_returning_null_for_void: true - avoid_returning_this: true - avoid_shadowing_type_parameters: true - avoid_single_cascade_in_expression_statements: true - avoid_types_on_closure_parameters: false - avoid_unnecessary_containers: false - avoid_unused_constructor_parameters: true - avoid_void_async: true - await_only_futures: true - camel_case_extensions: true - camel_case_types: true - cascade_invocations: true - cast_nullable_to_non_nullable: true - constant_identifier_names: true - curly_braces_in_flow_control_structures: true - deprecated_consistency: true - directives_ordering: true - do_not_use_environment: true - empty_catches: true - empty_constructor_bodies: true - eol_at_end_of_file: true - exhaustive_cases: true - file_names: true - flutter_style_todos: true - implementation_imports: true - join_return_with_assignment: true - leading_newlines_in_multiline_strings: true - library_names: true - library_prefixes: true - library_private_types_in_public_api: true - lines_longer_than_80_chars: true - missing_whitespace_between_adjacent_strings: true - no_default_cases: true - non_constant_identifier_names: true - noop_primitive_operations: true - null_check_on_nullable_type_parameter: true - null_closures: true - omit_local_variable_types: true - one_member_abstracts: true - only_throw_errors: true - overridden_fields: true - package_api_docs: true - package_prefixed_library_names: true - parameter_assignments: true - prefer_adjacent_string_concatenation: true - prefer_asserts_in_initializer_lists: true - prefer_asserts_with_message: true - prefer_collection_literals: true - prefer_conditional_assignment: true - prefer_const_constructors: false - prefer_const_constructors_in_immutables: true - prefer_const_declarations: false - prefer_const_literals_to_create_immutables: false - prefer_constructors_over_static_methods: true - prefer_contains: true - prefer_double_quotes: false - prefer_equal_for_default_values: true - prefer_expression_function_bodies: false - prefer_final_fields: true - prefer_final_in_for_each: false - prefer_final_locals: false - prefer_final_parameters: false - prefer_for_elements_to_map_fromIterable: true - prefer_foreach: true - prefer_function_declarations_over_variables: true - prefer_generic_function_type_aliases: true - prefer_if_elements_to_conditional_expressions: true - prefer_if_null_operators: true - prefer_initializing_formals: true - prefer_inlined_adds: true - prefer_int_literals: false - prefer_interpolation_to_compose_strings: true - prefer_is_empty: true - prefer_is_not_empty: true - prefer_is_not_operator: true - prefer_iterable_whereType: true - prefer_mixin: true - prefer_null_aware_method_calls: true - prefer_null_aware_operators: true - prefer_single_quotes: true - prefer_spread_collections: true - prefer_typing_uninitialized_variables: true - public_member_api_docs: false - recursive_getters: true - require_trailing_commas: true - sized_box_for_whitespace: true - slash_for_doc_comments: true - sort_child_properties_last: true - sort_constructors_first: true - sort_unnamed_constructors_first: true - tighten_type_of_initializing_formals: true - type_annotate_public_apis: true - type_init_formals: true - unawaited_futures: true - unnecessary_await_in_return: true - unnecessary_brace_in_string_interps: true - unnecessary_const: false - unnecessary_constructor_name: true - unnecessary_final: true - unnecessary_getters_setters: true - unnecessary_lambdas: true - unnecessary_new: true - unnecessary_null_aware_assignments: true - unnecessary_null_checks: true - unnecessary_null_in_if_null_operators: true - unnecessary_nullable_for_final_variable_declarations: true - unnecessary_overrides: true - unnecessary_parenthesis: true - unnecessary_raw_strings: true - unnecessary_string_escapes: true - unnecessary_string_interpolations: true - unnecessary_this: true - use_full_hex_values_for_flutter_colors: true - use_function_type_syntax_for_parameters: true - use_if_null_to_convert_nulls_to_bools: true - use_is_even_rather_than_modulo: true - use_late_for_private_fields_and_variables: true - use_named_constants: true - use_raw_strings: false - use_rethrow_when_possible: true - use_setters_to_change_properties: true - use_string_buffers: true - use_test_throws_matchers: true - use_to_and_as_if_applicable: true - void_checks: true - - -# Additional information about this file can be found at -# https://dart.dev/guides/language/analysis-options + rules: \ No newline at end of file diff --git a/example/lib/main.dart b/example/lib/main.dart index d4e0051..477ff7a 100644 --- a/example/lib/main.dart +++ b/example/lib/main.dart @@ -77,15 +77,15 @@ class _TrackTraceDemoState extends State { ], ), startPosition: Marker( - markerId: MarkerId('Start locatie'), - anchor: Offset(0.5, 0.5), - position: LatLng(52.356057, 4.897540), + markerId: const MarkerId('Start locatie'), + anchor: const Offset(0.5, 0.5), + position: const LatLng(52.356057, 4.897540), icon: startMarkerIcon ?? BitmapDescriptor.defaultMarker, ), destinationPosition: Marker( - markerId: MarkerId('Bestemming Locatie'), - anchor: Offset(0.5, 0.5), - position: LatLng(52.364709, 4.877157), + markerId: const MarkerId('Bestemming Locatie'), + anchor: const Offset(0.5, 0.5), + position: const LatLng(52.364709, 4.877157), icon: destinationMarkerIcon ?? BitmapDescriptor.defaultMarker, ), buildingsEnabled: false, @@ -93,7 +93,7 @@ class _TrackTraceDemoState extends State { travelMode: TravelMode.walking, mapType: MapType.normal, indoorViewEnabled: false, - routeUpdateInterval: Duration(seconds: 30), + routeUpdateInterval: const Duration(seconds: 30), timerPrecision: TimePrecision.everySecond, zoomGesturesEnabled: true, scrollGesturesEnabled: true, @@ -138,20 +138,20 @@ class _TrackTraceDemoState extends State { addBorder: true, borderColor: Colors.grey, title: 'Alex', - titleBackgroundColor: Color(0xffff7884), + titleBackgroundColor: const Color(0xffff7884), ); startMarkerIcon = bitmap; var bitmapDescriptor = await BitmapDescriptor.fromAssetImage( - ImageConfiguration(size: Size(100, 100)), + const ImageConfiguration(size: Size(100, 100)), 'assets/ic_location_on.png', ); setState(() { destinationMarkerIcon = bitmapDescriptor; controller?.end = Marker( - anchor: Offset(0.5, 0.5), - markerId: MarkerId('Bestemming Locatie'), - position: LatLng(52.364709, 4.877157), + anchor: const Offset(0.5, 0.5), + markerId: const MarkerId('Bestemming Locatie'), + position: const LatLng(52.364709, 4.877157), icon: bitmapDescriptor, ); }); @@ -177,7 +177,7 @@ class _TrackTraceDemoState extends State { controller!.route!.line.length > 1) { controller!.start = Marker( markerId: const MarkerId('Start Locatie'), - anchor: Offset(0.5, 0.5), + anchor: const Offset(0.5, 0.5), position: LatLng( controller!.route!.line[step].latitude, controller!.route!.line[step].longitude,