internal/flutter_availability
5
0
Fork 0
mirror of https://github.com/Iconica-Development/flutter_availability.git synced 2025-05-19 13:13:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: simplify DefaultConfirmationDialog usage by handling the possible null value internally

Browse source
This commit is contained in:
Bart Ribbers 2024-07-18 14:28:23 +02:00 committed by Freek van de Ven
parent bb337a4084
commit 226c90943a
4 changed files with 23 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter_availability/lib/src/config/availability_options.dart
View file

@ -198,7 +198,7 @@ typedef TimePickerBuilder = Future<TimeOfDay?> Function(
///
/// The function should return a [Future] that resolves to `true` if the user
/// confirms.
typedef ConfirmationDialogBuilder = Future<bool?> Function(
typedef ConfirmationDialogBuilder = Future<bool> Function(
BuildContext context, {
required String title,
required String description,

7
packages/flutter_availability/lib/src/ui/screens/availability_modification.dart
View file

@ -99,14 +99,13 @@ class _AvailabilitiesModificationScreenState
Future<void> onClickSave() async {
// TODO(Joey): The name confirmationDialogBuilder does not represent the
// expected implementation.
var confirmed = await options.confirmationDialogBuilder(
var isConfirmed = await options.confirmationDialogBuilder(
context,
title: translations.availabilityDialogConfirmTitle,
description: translations.availabilityDialogConfirmDescription,
);
// TODO(Joey): We should make the interface of the dialog function return
// a non nullable bool. Now we are implicitly setting default behaviour
if (confirmed ?? false) {
if (isConfirmed) {
await onSave();
}
}

4
packages/flutter_availability/lib/src/ui/screens/availability_overview.dart
View file

@ -111,12 +111,12 @@ class _AvailabilityOverviewState extends State<AvailabilityOverview> {
}
Future<void> onClearButtonClicked() async {
var confirmed = await options.confirmationDialogBuilder(
var isConfirmed = await options.confirmationDialogBuilder(
context,
title: translations.clearAvailabilityConfirmTitle,
description: translations.clearAvailabilityConfirmDescription,
);
if (confirmed ?? false) {
if (isConfirmed) {
await service
.clearAvailabilities(selectedAvailabilities.getAvailabilities());
setState(() {

27
packages/flutter_availability/lib/src/ui/widgets/default_confirmation_dialog.dart
View file

@ -13,19 +13,26 @@ class DefaultConfirmationDialog extends StatelessWidget {
});
/// Shows a confirmation dialog with a title and a description
static Future<bool?> builder(
static Future<bool> builder(
BuildContext context, {
required String title,
required String description,
}) =>
showModalBottomSheet(
context: context,
shape: const RoundedRectangleBorder(),
builder: (context) => DefaultConfirmationDialog(
title: title,
description: description,
),
);
}) async {
var isConfirmed = await showModalBottomSheet<bool>(
context: context,
shape: const RoundedRectangleBorder(),
builder: (context) => DefaultConfirmationDialog(
title: title,
description: description,
),
);
if (isConfirmed == null) {
return false;
}
return isConfirmed;
}
/// The title shown in the dialog
final String title;