fix: don't use initState when the variable can be instatiated through the class definition instead

This commit is contained in:
Bart Ribbers 2024-07-18 14:24:32 +02:00 committed by Freek van de Ven
parent f5962acf7a
commit 1d65ac5096

View file

@ -49,18 +49,7 @@ class AvailabilitiesModificationScreen extends StatefulWidget {
class _AvailabilitiesModificationScreenState class _AvailabilitiesModificationScreenState
extends State<AvailabilitiesModificationScreen> { extends State<AvailabilitiesModificationScreen> {
late AvailabilityModel _availability; late AvailabilityModel _availability =
late List<AvailabilityTemplateModel> _selectedTemplates;
bool _clearAvailability = false;
TimeOfDay? _startTime;
TimeOfDay? _endTime;
@override
void initState() {
super.initState();
// TODO(Joey): These can be immediately assigned to the properties
// This removes the need for an initState
_availability =
widget.initialAvailabilities.getAvailabilities().firstOrNull ?? widget.initialAvailabilities.getAvailabilities().firstOrNull ??
AvailabilityModel( AvailabilityModel(
userId: "", userId: "",
@ -68,8 +57,11 @@ class _AvailabilitiesModificationScreenState
endDate: widget.dateRange.end, endDate: widget.dateRange.end,
breaks: [], breaks: [],
); );
_selectedTemplates = widget.initialAvailabilities.getUniqueTemplates(); late List<AvailabilityTemplateModel> _selectedTemplates =
} widget.initialAvailabilities.getUniqueTemplates();
bool _clearAvailability = false;
TimeOfDay? _startTime;
TimeOfDay? _endTime;
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {